Skip to content

oauth: redefine gating mode as pure OAuth resource server (#109) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Slach merged 5 commits into from
May 11, 2026
Merged

oauth: redefine gating mode as pure OAuth resource server (#109) #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5cd4e87
oauth: redefine gating mode as pure OAuth resource server (#109)
BorisTyshkevich May 9, 2026
124335b
oauth: refuse gating + AS-side fields at startup (#109)
BorisTyshkevich May 9, 2026
845149d
test(oauth): drop gating-AS test groups + add Audience to gating fixt…
BorisTyshkevich May 9, 2026
93008c7
docs: rewrite OAuth mode taxonomy for #109 (pure resource server)
BorisTyshkevich May 9, 2026
3ab6738
oauth: accept namespaced email claim for CH impersonation under #109
BorisTyshkevich May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions cmd/altinity-mcp/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,36 @@ func validateOAuthRuntimeConfig(cfg config.Config) error {
"without it, any IdP-issued token with email_verified=false can impersonate the named CH user via initial_user")
}

// #109: gating mode is now a pure OAuth resource server (Auth0-fronted).
// The fields below belong to the gating-AS role that is being removed.
// Refuse at startup so operators notice and clean up helm values.
if cfg.Server.OAuth.IsGatingMode() {
if cfg.Server.OAuth.ClientID != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.client_id — remove from helm values; client_id is now Auth0's responsibility under #109")
}
if cfg.Server.OAuth.ClientSecret != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.client_secret — remove from helm values; client_secret is now Auth0's responsibility under #109")
}
if cfg.Server.OAuth.TokenURL != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.token_url — remove from helm values; token_url is now Auth0's responsibility under #109")
}
if cfg.Server.OAuth.AuthURL != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.auth_url — remove from helm values; auth_url is now Auth0's responsibility under #109")
}
if cfg.Server.OAuth.UserInfoURL != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.userinfo_url — remove from helm values; userinfo_url is now Auth0's responsibility under #109")
}
if cfg.Server.OAuth.PublicAuthServerURL != "" {
return fmt.Errorf("oauth: gating mode forbids oauth.public_auth_server_url — remove from helm values; public_auth_server_url is now Auth0's responsibility under #109")
}
if strings.TrimSpace(cfg.Server.OAuth.Issuer) == "" {
return fmt.Errorf("oauth: gating mode requires oauth.issuer (the upstream AS, e.g. https://altinity.auth0.com/) to be set")
}
if strings.TrimSpace(cfg.Server.OAuth.Audience) == "" {
return fmt.Errorf("oauth: gating mode requires oauth.audience to byte-equal the MCP public URL (RFC 8707)")
}
}

return nil
}

Expand Down
11 changes: 9 additions & 2 deletions cmd/altinity-mcp/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,9 +3288,11 @@ func TestValidateOAuthRuntimeConfig(t *testing.T) {
t.Run("valid_gating_config", func(t *testing.T) {
t.Parallel()
cfg := config.Config{Server: config.ServerConfig{OAuth: config.OAuthConfig{
Enabled: true,
Mode: "gating",
Enabled: true,
Mode: "gating",
SigningSecret: "test-signing-secret-32-byte-key!!",
Issuer: "https://example.auth0.com/",
Audience: "https://example-mcp.test/",
}}}
require.NoError(t, validateOAuthRuntimeConfig(cfg))
})
Expand All @@ -3317,6 +3319,7 @@ func TestValidateOAuthRuntimeConfig(t *testing.T) {
Enabled: true,
Mode: "gating",
SigningSecret: "test-signing-secret-32-byte-key!!",
Issuer: "https://example.auth0.com/",
RequireEmailVerified: false,
}},
ClickHouse: config.ClickHouseConfig{
Expand All @@ -3337,6 +3340,8 @@ func TestValidateOAuthRuntimeConfig(t *testing.T) {
Enabled: true,
Mode: "gating",
SigningSecret: "test-signing-secret-32-byte-key!!",
Issuer: "https://example.auth0.com/",
Audience: "https://example-mcp.test/",
RequireEmailVerified: true,
}},
ClickHouse: config.ClickHouseConfig{
Expand All @@ -3357,6 +3362,8 @@ func TestValidateOAuthRuntimeConfig(t *testing.T) {
Enabled: true,
Mode: "gating",
SigningSecret: "test-signing-secret-32-byte-key!!",
Issuer: "https://example.auth0.com/",
Audience: "https://example-mcp.test/",
RequireEmailVerified: false,
}},
ClickHouse: config.ClickHouseConfig{Protocol: config.TCPProtocol},
Expand Down
Loading