fix: cap schema-card skip-index line at MAX_IDX#118
Merged
Conversation
A heavily-indexed table (e.g. an OTel log table with a bloom filter per Map key/value plus a tokenbf on the body) joined every skip-index onto one unbounded idx: line, blowing the fullscreen schema graph card (and its layout) out of proportion — unlike columns, which already cap at MAX_COLS with an overflow indicator. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xwt1KZ3rmKfM26jvyZQD2t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idx:line — unlike columns, which already cap atMAX_COLS(16) with a "+N more" indicator.Mapkey/value column plus atokenbf_v1on the body — 8 indexes total) produced a single line ~1700px wide, blowing the card and the whole graph layout out of proportion.buildCardModelnow caps the skip-index line at a newCARD.MAX_IDX(6) constant with a+N moresuffix, mirroring the columns' overflow pattern.Test plan
npm test— 1297/1297 passing, coverage gate unaffected (verified pre-existing branch-coverage gaps are unchanged, not newly introduced)buildCardGraph/buildRichSchemaSvg) and rendering it in a real browser via Playwright, confirming the fix caps the line and keeps the card in proportion🤖 Generated with Claude Code
https://claude.ai/code/session_01Xwt1KZ3rmKfM26jvyZQD2t