Prevent nested ssh from consuming while loop stdin#1368
Merged
Conversation
Slach
approved these changes
May 13, 2026
Collaborator
Slach
left a comment
Slach
left a comment
There was a problem hiding this comment.
nice catch, thanks for contribution
Author
|
Failed test is not related to changes: |
Signed-off-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
Author
|
Rebased to master. @Slach PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed backup iteration over SSH.
The nested
sshcommand was consuming stdin from thewhile readloop, causing only the first backup to be processed. This change usesssh -nto prevent stdin interference and ensures all backup metadata files are processed correctly.