fix: better error message about missing download.state2 file#1385
Merged
Slach merged 4 commits intoMay 29, 2026
Merged
Conversation
Treat download.state2 as optional for --resume so an existing backup directory without state can be validated and resumed from scratch.
Slach
requested changes
May 28, 2026
Collaborator
Slach
left a comment
Slach
left a comment
There was a problem hiding this comment.
See #1383 (comment) — auto-fallback to scratch download when download.state2 is missing is not safe (silent corruption risk: no way to know which local files are complete vs cut mid-stream). The acceptable fix is improving the error message to point at clickhouse-backup delete local <name>, not changing the behavior. Not merging this as-is.
Slach
requested changes
May 28, 2026
| return ErrBackupIsAlreadyExists | ||
| } else { | ||
| _, checkDownloadErr := os.Stat(path.Join(b.DefaultDataPath, "backup", backupName, "download.state2")) | ||
| if errors.Is(checkDownloadErr, os.ErrNotExist) { |
Collaborator
There was a problem hiding this comment.
better return here following error
local backup '<name>' exists but download.state2 is missing.
run `clickhouse-backup delete local <name>` and retry,
or investigate why the resumable state was lost.
…ermes-auto/clickhouse-backup-1383-resume-missing-state
Slach
changed the title
Slach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download --resumeto continue when the local backup directory exists butdownload.state2is missingTests
go test ./pkg/backup -run TestResumeExistingBackupAllowsMissingStateFile -count=1go test ./pkg/backup -count=1Closes #1383