Skip to content

huge refactoring for S3#1409

Merged
Slach merged 1 commit into
masterfrom
aws_sdk_update
Jun 5, 2026
Merged

huge refactoring for S3#1409
Slach merged 1 commit into
masterfrom
aws_sdk_update

Conversation

@Slach
Copy link
Copy Markdown
Collaborator

@Slach Slach commented Jun 5, 2026

replace deprecated github.com/aws/aws-sdk-go-v2/feature/s3/manager to github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager, remove S3_BUFFER_SIZE

…-v2/feature/s3/manager to github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager, remove S3_BUFFER_SIZE
@Slach Slach added this to the 2.7.1 milestone Jun 5, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 27004419729

Coverage decreased (-0.08%) to 64.774%

Details

  • Coverage decreased (-0.08%) from the base build.
  • Patch coverage: 3 uncovered changes across 1 file (39 of 42 lines covered, 92.86%).
  • 25 coverage regressions across 5 files.

Uncovered Changes

File Changed Covered %
pkg/storage/s3.go 42 39 92.86%

Coverage Regressions

25 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
pkg/storage/gcs.go 17 54.63%
pkg/backup/create.go 2 74.72%
pkg/backup/list.go 2 57.58%
pkg/clickhouse/clickhouse.go 2 78.86%
pkg/storage/structs.go 2 84.0%

Coverage Stats

Coverage Status
Relevant Lines: 21555
Covered Lines: 13962
Line Coverage: 64.77%
Coverage Strength: 36452.03 hits per line

💛 - Coveralls

@Slach Slach merged commit 817d63b into master Jun 5, 2026
45 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants