Skip to content

try to parallelize test jobs#866

Merged
Slach merged 10 commits intomasterfrom
test-parallel
Mar 10, 2026
Merged

try to parallelize test jobs#866
Slach merged 10 commits intomasterfrom
test-parallel

Conversation

@lunaticusgreen
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Mar 5, 2026

Pull Request Test Coverage Report for Build 22716597308

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 695 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-22.1%) to 40.141%

Files with Coverage Reduction New Missed Lines %
pkg/requests/request_response.go 4 0.0%
pkg/main.go 5 0.0%
pkg/query.go 54 0.0%
pkg/eval/eval_query.go 59 76.56%
pkg/resource_handlers.go 59 0.0%
pkg/client.go 77 0.0%
pkg/datasource.go 85 0.0%
pkg/response.go 161 0.0%
pkg/parser.go 191 0.0%
Totals Coverage Status
Change from base Build 22607053745: -22.1%
Covered Lines: 1476
Relevant Lines: 3677

💛 - Coveralls

@Selfeer
Copy link
Collaborator

Selfeer commented Mar 5, 2026

You don't really need a custom solution like should_run() and suite, instead you can just rely on the --only flag, even with your matrix approach to have something like:

- group: window-functions
  only: "*/window functions/*"
- group: legacy-alerts
  only: "*/legacy alerts/*"

-----------------------------------------

run: cd ./tests/testflows/ &&
  python3 -u ./regression.py
  --before=0.1 --after=0.1
  --only "${{ matrix.only }}"
  --log raw.log -o new-fails

But generally we've moved to using a reusable-suite for most our projects:

https://github.com/Altinity/clickhouse-regression/blob/main/.github/workflows/reusable-suite.yml

These are the most basic comments that I have that can make you approach cleaner, but generally I would just point an AI agent to our clickhouse-regression suite and make it take our approach. right now your regression.py looks a bit messy.

Also as a note: keep -o new-fails - The PR downgrades to -o short, losing the most useful CI output format.

# user: root
links:
- grafana
- grafana_legacy_alerts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you remove it?

depends_on:
- grafana
- trickster
- grafana_legacy_alerts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you remove it?

Slach and others added 3 commits March 10, 2026 07:47
GitHub Actions YAML parser was truncating "12.4.0-20977568970" to 12.4.
Using ${{ '...' }} expression syntax to guarantee string handling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts:
#	.github/workflows/testflows.yml
@Slach Slach merged commit a68430b into master Mar 10, 2026
14 checks passed
@Slach Slach added this to the 3.4.10 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants