Removes CHIT Resources & Deprecated Charts#50
Merged
joshleecreates merged 7 commits intomainfrom Aug 11, 2025
Merged
Conversation
Previously the chart used `ClickHouseInstallationTemplate` resources which caused delays in reconcillition. This simplification means updates are now applied immediately when a new helm release is created. Note that existing CHIT resources will need to be deleted manually. fixes #48
hodgesrm
requested changes
Aug 7, 2025
Member
hodgesrm
left a comment
hodgesrm
left a comment
There was a problem hiding this comment.
This review is scoped to clickhouse changes only. clickhouse-eks needs a separate review.
-
Values.yaml should be updated to latest image altinity/clickhouse-server:25.3.6.10034.altinitystable
-
chk.yaml is generating the template for CHK resource the wrong way. It's multiplying specs for each keeper replica. Instead, you can just set replicasCount in the spec. You can just imitate https://github.com/Altinity/antalya-examples/blob/main/kubernetes/manifests/keeper.yaml. Current implementation fails to bring up keeper on eks because scale-up fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the chart used
ClickHouseInstallationTemplateresourceswhich caused delays in reconcillition. This simplification means updates
are now applied immediately when a new helm release is created.
Note that existing CHIT resources will need to be deleted manually.
fixes #48