This repository was archived by the owner on Oct 13, 2025. It is now read-only.
mrosvik/patternlab-cleanup #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platesAndPagesArchive. npm start now runs in 8-20sec. This is a temporary fix until we have a new patternlab version innstalled without the inheritance plugin. To work with templates and pages, copy the files you need from archive into patterns.
…f all templates and pages are moved back into patterns
This reverts commit 251771e.
magnusnn
approved these changes
Jan 4, 2021
ma31cm
pushed a commit
that referenced
this pull request
Jan 11, 2021
* moved all pages and templates out of patterns into archive folder templatesAndPagesArchive. npm start now runs in 8-20sec. This is a temporary fix until we have a new patternlab version innstalled without the inheritance plugin. To work with templates and pages, copy the files you need from archive into patterns. * removed brsys from patternlab * removed broken links to archived pages. This commit can be reverted if all templates and pages are moved back into patterns * Revert "removed brsys from patternlab" This reverts commit 251771e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our patternlab has grown large and is struggling to run "npm start". It crashes with error "javascript heap out of memory". With "gulp --max_old_space_size=9000" it completes, but takes almost an hour(!) We decided to move templates and pages into an archived folder outside of patterns, so it is possible to update components, CSS and javascript, which currently is the most important task. To work with templates and pages, copy the files you need from archive into patterns. Some links are removed, but since prototyping is happening mostly in Figma now, it should not be a big problem. We might considering moving templates and pages back into patterns, if we can make the build work quick again some way.
This pull request includes 2 commits: