chore: disable SonarCloud scan for forks#301
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
olemartinorg
approved these changes
Jun 29, 2022
Contributor
olemartinorg
left a comment
olemartinorg
left a comment
There was a problem hiding this comment.
SonarCloud seems to be happy about this change, and so am I. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds from forks always result in a failed check, because they do not have access to the
SONAR_TOKENsecret. This is very annoying. We investigated possibilities to be able to run this check in a separate workflow which had access to the secret in #255 , but it turned out to be a bit complex, and not worth the trouble.We should instead disable SonarCloud scan on forks, and if we want coverage checks (or other checks) from forks, we should add other tools to our pipeline (tools which ideally do not require any secrets, because then we get into the same problem again)
Related Issue(s)
Verification