Review Lua lpmlib #506
Merged
Review Lua lpmlib #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, Lua lpmlib would wrongly read IPv6 addresses coming from Lua policies. This behavior would lead to a number of problems such as not finding the IPv6 address during lookups, returning wrong masks, and adding wrong addresses to an IPv6 LPM table. Not only does this patch fix the bug described above, it also make easier for Lua policies to pass IPv6 addresses to lpmlib. From now on, all functions in lpmlib that receive IPv6 addresses accept IPv6 addresses as struct in6_addr, references to struct in6_addr, or pointers to struct in6_addr.
Since casting is no longer needed to pass IPv6 addresses to Lua lpmlib, this patch drops them from the example policy.
AltraMayor
added
bug
enhancement
Production requirement
Owner
Author
|
Tested on our XIA1 server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds information to some of the error messages of the Lua
lpmlibto help diagnoses in production, fixes a bug while passing IPv6 addresses from Lua policies tolpmlib, and makeslpmlibaccepting IPv6 addresses in any type.