gk: forbid del_fib_entry_locked() to delete neighbor entries #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify remove_prefix_from_lpm_locked() by reusing check_prefix_exists_locked().
There are two motivations to drop remove_prefix_from_lpm_locked(): 1. Thanks to the simplification of remove_prefix_from_lpm_locked(), what was accomplished in the previous patch, having its whole code within del_fib_entry_locked(), its only caller, became reasonable. 2. This prepares del_fib_entry_locked() for the following patch, which addresses an issue of del_fib_entry_locked().
Owner
Author
|
Tested on XIA1 server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
del_fib_entry_locked()on a neighbor prefix would've put Gatekeeper's FIB table in an inconsistent state. Besides this problem, there's no need to remove neighbor prefixes. This pull request forbids the operation.