This repository was archived by the owner on Apr 30, 2026. It is now read-only.
fix: replace removeprefix/removesuffix for Python 3.8 compatibility#1
Open
fix: replace removeprefix/removesuffix for Python 3.8 compatibility#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug described in issue jorio#45.
What was wrong: The build.py script used
str.removeprefix()andstr.removesuffix()methods which were introduced in Python 3.9. When running on Python 3.8 (or earlier Python 3 versions), this causesAttributeError: 'str' object has no attribute 'removeprefix'.How I fixed it: Replaced the chained
value.removeprefix('"').removesuffix('"')call with a simple manual check usingstartswith()andendswith()with string slicing:if value.startswith('"') and value.endswith('"'): value = value[1:-1]Tested by: The fix is a direct equivalent that works on Python 3.6+ (all currently supported Python versions per PEP 494). The syntax was verified to parse correctly.
Fixes jorio#45