feat: add IAM workflow validation and fix partial role ARN handling#40
Merged
Conversation
- Added validate() to SpinUpEKSIAMInput (requires ClusterName, Environment, Team) and SpinDownEKSIAMInput (requires both role names); both IAM workflows now return NonRetryableApplicationError on invalid input - SpinUpInput.validate() now rejects the case where exactly one of ClusterRoleARN/NodeRoleARN is set, preventing silent role recreation - Renamed SpinUpIAMInput/Output and SpinDownIAMInput to SpinUpEKSIAMInput/Output and SpinDownEKSIAMInput to reflect that these roles are EKS-specific Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate()toSpinUpEKSIAMInput(requiresClusterName,Environment,Team) andSpinDownEKSIAMInput(requires both role names); both IAM workflows now returnNonRetryableApplicationErroron invalid input, consistent with all other workflowsSpinUpInput.validate()now rejects the case where exactly one ofClusterRoleARN/NodeRoleARNis provided — previously this silently ignored the supplied ARN and created both roles from scratchSpinUpIAMInput,SpinUpIAMOutput, andSpinDownIAMInputtoSpinUpEKSIAMInput,SpinUpEKSIAMOutput, andSpinDownEKSIAMInputto make clear these are EKS-specific typesTest plan
go build ./...passesSpinUpIAMWorkflowwith emptyClusterName— fails immediately with non-retryable errorSpinDownIAMWorkflowwith emptyClusterRoleName— fails immediately with non-retryable errorSpinUpWorkflowwith onlyClusterRoleARNset (noNodeRoleARN) — fails validation before any AWS calls🤖 Generated with Claude Code