Skip to content

test: rewrite workflow tests using Ginkgo and Gomega#45

Merged
Amertz08 merged 5 commits into
mainfrom
claude/ginkgo-tests
May 15, 2026
Merged

test: rewrite workflow tests using Ginkgo and Gomega#45
Amertz08 merged 5 commits into
mainfrom
claude/ginkgo-tests

Conversation

@Amertz08
Copy link
Copy Markdown
Owner

Summary

  • Installs Ginkgo v2 and Gomega and rewrites all workflow tests from testify suite style to Ginkgo Describe/Context/It blocks with Gomega matchers
  • Adds a shared suite_test.go with a single TestWorkflows bootstrap so all specs run exactly once
  • Retains testify/mock and go.temporal.io/sdk/testsuite since the Temporal test env depends on them for activity mocking
  • Converts infra helper functions from suite methods to plain functions accepting env as a parameter

Test plan

  • go test -v ./internal/workflows/... — all 22 specs pass under TestWorkflows

🤖 Generated with Claude Code

Amertz08 and others added 5 commits May 14, 2026 21:21
Replaces the testify suite with Ginkgo Describe/Context/It blocks and
Gomega matchers. Temporal testsuite and testify/mock are retained since
the Temporal test env depends on them for activity mocking.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Moves RunSpecs to a single TestWorkflows entry point so that all Ginkgo
Describe blocks in the package run once rather than duplicating across
per-file bootstrap functions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Amertz08 Amertz08 merged commit 6092164 into main May 15, 2026
1 check passed
@Amertz08 Amertz08 deleted the claude/ginkgo-tests branch May 15, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant