Add veil-proxy as separate command line tool.#46
Merged
NullHypothesis merged 10 commits intomasterfrom Dec 25, 2024
Merged
Conversation
This has several advantages: * There's no need to worry about moving shared code to a `pkg/` directory. * Having a single version is much easier to keep track of than several versions that increas independently. * A single directory is easier to keep track of than multiple.
In particular: * Move veil's, veil-verify's, and veil-proxy's configuration to the `config` package. * Add `validate.Object`, which validates a given object and turns validation errors into joined errors. * Unify the way we handle configuration across our three command line tools.
...and make both veil and veil-proxy use the same default port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has several advantages:
There's no need to worry about moving shared code to a
pkg/directory.Having a single version is much easier to keep track of than several versions that evolve independently.
A single directory is easier to keep track of than multiple.