Skip to content

Conversation

@zhuozl
Copy link

@zhuozl zhuozl commented Jun 16, 2025

支持在网关采用 MCP 协议、后端服务使用 SSE 协议的场景下,实现对后端工具的获取与调用功能。

Summary by Sourcery

Add support for fetching and invoking backend tools over SSE transport in the MCP server.

New Features:

  • Enable tool discovery via SSE backend protocol using FetchTools.
  • Enable tool invocation over SSE protocol through CallTool with error handling when transport is missing or execution fails.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 16, 2025

Reviewer's Guide

This PR integrates support for fetching and invoking backend tools over SSE in the MCP gateway scenario by retrieving the SSE transport from server state and delegating tool operations to it with proper error handling.

Sequence Diagram for Fetching Tools via SSE Transport

sequenceDiagram
    actor User
    participant MCPGateway
    participant State
    participant SSETransport
    participant BackendServiceSSE

    User->>MCPGateway: MCP Request (method: tools/list, protocol: SSE)
    MCPGateway->>State: GetTransport(conn.Meta().Prefix)
    State-->>MCPGateway: transport (SSETransport instance)
    alt transport is available
        MCPGateway->>SSETransport: FetchTools(context)
        activate SSETransport
        SSETransport->>BackendServiceSSE: Fetch tools over SSE
        BackendServiceSSE-->>SSETransport: Tools data
        deactivate SSETransport
        SSETransport-->>MCPGateway: tools
        MCPGateway-->>User: MCP Response (tools)
    else transport is nil OR FetchTools fails
        MCPGateway-->>User: MCP Response (Error: Failed to fetch tools)
    end
Loading

Sequence Diagram for Calling a Tool via SSE Transport

sequenceDiagram
    actor User
    participant MCPGateway
    participant State
    participant SSETransport
    participant BackendServiceSSE

    User->>MCPGateway: MCP Request (method: tools/call, params, protocol: SSE)
    MCPGateway->>State: GetTransport(conn.Meta().Prefix)
    State-->>MCPGateway: transport (SSETransport instance)
    alt transport is available
        MCPGateway->>SSETransport: CallTool(context, params, requestInfo)
        activate SSETransport
        SSETransport->>BackendServiceSSE: Execute tool over SSE with params
        BackendServiceSSE-->>SSETransport: Tool result
        deactivate SSETransport
        SSETransport-->>MCPGateway: result
        MCPGateway-->>User: MCP Response (result)
    else transport is nil OR CallTool fails
        MCPGateway-->>User: MCP Response (Error: Tool execution error or config not found)
    end
Loading

Class Diagram: Server Interaction with SSE Transport

classDiagram
    class Server {
        +state: State
        +handleMCPRequest(c gin.Context, req mcp.JSONRPCRequest, conn session.Conn)
    }
    class State {
        +GetTransport(prefix string) Transport
    }
    class Transport {
        <<Interface>>
        +FetchTools(ctx context.Context) []Tool
        +CallTool(ctx context.Context, params any, reqInfo any) any
    }
    class SSETransport {
        +FetchTools(ctx context.Context) []Tool
        +CallTool(ctx context.Context, params any, reqInfo any) any
    }

    Server o-- State : uses
    State ..> Transport : provides
    Transport <|.. SSETransport : implements
Loading

File-Level Changes

Change Details Files
Reorder imports for consistency
  • Moved github.com/google/uuid import below mcp pkg imports
internal/core/streamable.go
Implement tool fetching over SSE
  • Retrieve transport via state.GetTransport
  • Handle nil transport with protocol error
  • Call transport.FetchTools and handle errors
internal/core/streamable.go
Implement tool invocation over SSE
  • Retrieve transport via state.GetTransport
  • Handle missing transport with 404 protocol error
  • Invoke transport.CallTool with merged request info
  • Handle execution errors via sendToolExecutionError
internal/core/streamable.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zhuozl - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@iFurySt iFurySt merged commit 55a5ffd into AmoyLab:main Jun 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants