Skip to content

feat: add apistore#52

Merged
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:feat/add-apistore
May 12, 2025
Merged

feat: add apistore#52
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:feat/add-apistore

Conversation

@qiankunli
Copy link
Copy Markdown
Contributor

@qiankunli qiankunli commented May 12, 2025

Summary by Sourcery

Introduce an API-based storage backend, allowing configuration retrieval from a remote HTTP server, and update related configuration and factory logic to support this new storage type.

New Features:

  • Add support for API-based storage backend with configuration options for URL and JSON path.

Enhancements:

  • Update storage factory to support API storage type.

Build:

  • Bump github.com/tidwall/gjson dependency version.

Documentation:

  • Document API storage configuration in mcp-gateway.yaml example.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 12, 2025

Reviewer's Guide

This pull request introduces a new API-based storage backend (APIStore) for configuration, updates the configuration schema and factory logic to support it, and adds related configuration options and dependencies.

File-Level Changes

Change Details Files
Introduced APIStore as a new storage backend for configuration via HTTP API.
  • Added APIStorageConfig struct to configuration schema.
  • Implemented APIStore struct and methods (Create, Get, List, Update, Delete) for remote config retrieval via HTTP and gjson path extraction.
  • Added NewAPIStore constructor and integrated it into the storage factory.
internal/common/config/storage.go
internal/mcp/storage/api.go
internal/mcp/storage/factory.go
Extended configuration files and environment variables to support API storage backend.
  • Added api section to storage config in YAML and .env.example for URL and configJSONPath.
configs/mcp-gateway.yaml
.env.example
Updated dependency for gjson to support new features required by APIStore.
  • Bumped github.com/tidwall/gjson from v1.14.4 to v1.18.0 in go.mod and go.sum.
go.mod
go.sum

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qiankunli - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread internal/mcp/storage/api.go Outdated
Comment thread internal/mcp/storage/api.go
Comment on lines +42 to +46
// only use for read config
return nil
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Store methods for Create, Update, and Delete are no-ops.

Consider returning an explicit error (e.g., ErrNotSupported) to clearly indicate these operations aren’t supported.

Copy link
Copy Markdown
Member

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!❤️

@iFurySt iFurySt merged commit d2d9fd2 into AmoyLab:main May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants