Skip to content

feat: add redis username#60

Merged
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:feat/add-redis-username
May 13, 2025
Merged

feat: add redis username#60
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:feat/add-redis-username

Conversation

@qiankunli
Copy link
Copy Markdown
Contributor

@qiankunli qiankunli commented May 13, 2025

Summary by Sourcery

New Features:

  • Support specifying Redis username for notifier and session storage

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 13, 2025

Reviewer's Guide

Introduces a Redis username parameter across notifier and session components by extending configuration structs, constructors, factory calls, and updating YAML examples to support authentication via username.

File-Level Changes

Change Details Files
Propagate Redis username through notifier initialization and adjust imports
  • Extended NewNotifier calls in factory to pass username
  • Modified NewRedisNotifier signature to accept username
  • Reordered import statements to group config import after zap
internal/mcp/storage/notifier/factory.go
internal/mcp/storage/notifier/redis.go
Propagate Redis username through session store initialization
  • Extended NewRedisStore signature to accept username
  • Updated NewStore factory call to pass username
internal/mcp/session/redis.go
internal/mcp/session/factory.go
Add username field to Redis configuration structs
  • Added Username field to SessionRedisConfig
  • Added Username field to RedisConfig in notifier config
internal/common/config/config.go
internal/common/config/notifier.go
Update YAML examples to include Redis username
  • Added username entries under notifier.redis and session.redis in mcp-gateway.yaml
  • Updated .env.example to include NOTIFIER_REDIS_USERNAME and SESSION_REDIS_USERNAME
configs/mcp-gateway.yaml
.env.example

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qiankunli - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Member

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@iFurySt iFurySt merged commit c9b8221 into AmoyLab:main May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants