Skip to content

fix: add MCPConfig json tag#96

Merged
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:fix/add-mcpconfig-json-tag
May 19, 2025
Merged

fix: add MCPConfig json tag#96
iFurySt merged 1 commit into
AmoyLab:mainfrom
qiankunli:fix/add-mcpconfig-json-tag

Conversation

@qiankunli
Copy link
Copy Markdown
Contributor

@qiankunli qiankunli commented May 19, 2025

Summary by Sourcery

Add and standardize JSON and YAML struct tags throughout MCP configuration types for consistent serialization

Enhancements:

  • Add JSON tags to MCPConfig and all nested configuration structs to enable JSON serialization
  • Normalize YAML tags for timestamp fields to use camelCase in MCPServer and MCPConfig
  • Align JSON and YAML tags across RouterConfig, CORSConfig, ServerConfig, ToolConfig, MCPServerConfig, ArgConfig, and ItemsConfig for consistent field mappings

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 19, 2025

Reviewer's Guide

This PR introduces consistent JSON serialization by adding json tags alongside existing yaml tags and normalizing field naming (especially timestamps) across the MCPServer, MCPConfig, and all nested config types in internal/common/config/mcp.go.

File-Level Changes

Change Details Files
Added JSON tags and standardized YAML tags on top-level config structs
  • Added json tags to MCPServer.CreatedAt and UpdatedAt
  • Added json tags to MCPConfig Name, Tenant, CreatedAt, UpdatedAt, DeletedAt
  • Added json tags to MCPConfig slice fields (Routers, Servers, Tools, McpServers)
  • Normalized yaml tags for timestamp fields to camelCase
internal/common/config/mcp.go
Added JSON tags and aligned YAML tags in nested types
  • Added json tags to RouterConfig and CORSConfig fields
  • Added json tags to ServerConfig and ToolConfig fields
  • Added json tags to MCPServerConfig for all fields
  • Added json tags to ArgConfig and ItemsConfig
  • Ensured yaml tags mirror json tag casing and include omitempty where applicable
internal/common/config/mcp.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Member

@iFurySt iFurySt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qiankunli - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@iFurySt iFurySt merged commit 8bc67fa into AmoyLab:main May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants