Skip to content

Conversation

@tmi
Copy link
Collaborator

@tmi tmi commented Aug 29, 2022

Adding two goodies I'm needing right now:

  • configurable credentials for s3. No longer relying on reading from env vars, now those can be explicitly passed. Both to fs instance, and to a global config holder. Not optimal rn, but an improvement
  • IdentityReader -- pretty much ls without a read. Fits nicely to the design

@tmi tmi requested a review from ampx-mg August 29, 2022 12:20
Copy link
Collaborator

@ampx-mg ampx-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tmi tmi merged commit 7983689 into AmpX-AI:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants