Replace NamedTuple with dataclass #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi btw 😉 |
Contributor
|
hi :) I'll look at this tomorrow, I just wonder why did I not use the dataclass in the first place... (ie, why did I chose NamedTuple, which aint my fav thing...) |
Collaborator
|
nothing seems broken so I guess all is well. I still fear that there is something lurking around the generics, it just got hidden by some of the other I will proceed with adding py3.9 to the regular test suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the ways to solve #23. Don't know whether immutability is of importance here but just to be safe I used
frozen=True. I had to tweak the tests a bit but accessing attributes directly rather than by subscribing seems better to me.