Skip to content

Run python 3.9 tests #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmi merged 4 commits into from
Oct 10, 2022
Merged

Run python 3.9 tests #26

tmi merged 4 commits into from
Oct 10, 2022

Conversation

@tmi
Copy link
Collaborator

@tmi tmi commented Sep 24, 2022

  • Adding a parallel run of a test for py39.
  • Nothing around release etc changed -- the wheel should be version-independent (we claim py>=3.8, we may want to restrict from above, only for the python versions we test for... latest when we hit some bug in high pythons we cannot fix)
  • Added minor convenience to Makefile

@tmi tmi requested a review from ampx-mg September 24, 2022 11:51
@tmi tmi changed the title Py39 Run python 3.9 tests Sep 24, 2022
ampx-mg
ampx-mg approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@ampx-mg ampx-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@tmi tmi merged commit c6768bc into AmpX-AI:main Oct 10, 2022
@tmi tmi deleted the py39 branch October 10, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ampx-mg ampx-mg ampx-mg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmi @ampx-mg