Skip to content

Conversation

@tmi
Copy link
Collaborator

@tmi tmi commented Nov 14, 2022

A few things of interest:

  • addition of py.typed. This tells mypy that the package is aware of types and those should be respected
  • addition of MANIFEST.in and include_package_files in setup.cfg -- this is so that the py.typed actually gets used in build (but in a way that the .build-venv is not included)
  • move of the ./fsql to ./src/fsql -- this will make it easier once we create some sub-module inside fsql (we would have to include it by hand in setup.cfg otherwise). This triggered small updates in setup.cfg and isort.cfg

@vojtechtuma-imi
Copy link
Contributor

huh this one got forgotten it seems... @ampx-mg do you want to have a look and possibly approve?

@ampx-mg ampx-mg self-requested a review February 6, 2023 15:31
Copy link
Collaborator

@ampx-mg ampx-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tmi tmi merged commit 55b3ebe into AmpX-AI:main Feb 6, 2023
@tmi tmi deleted the mypyDownstreamSupport branch February 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants