Add write support to json from pd.DataFrame #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampx-mg
force-pushed
the
mg/add_json_write_support
branch
from
d036b83 to
a413a36
Compare
tmi
approved these changes
Feb 6, 2023
Collaborator
tmi
left a comment
tmi
left a comment
There was a problem hiding this comment.
lgtm; the conflict with main is something trivial after the merge of that py.typed branch... you can just merge this one after fixing
ampx-mg
force-pushed
the
mg/add_json_write_support
branch
from
ecbfd13 to
bf3ff13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #5 this PR adds a
write_objectsupport forformat="json"frompd.DataFrameto json file. Adds tests as well.