[Bug] Broken JSON Resume Schema Importing

[Shadowfita]

Is there an existing issue for this?

• Yes, I have searched the existing issues and none of them match my problem.

Product Variant

Cloud (https://rxresu.me)

Current Behavior

Importing a valid JSON resume results in an error on both self-hosted and cloud, with this response:

{
    "issues": [
        {
            "code": "too_small",
            "minimum": 1,
            "type": "string",
            "inclusive": true,
            "exact": false,
            "message": "String must contain at least 1 character(s)",
            "path": [
                "data",
                "sections",
                "experience",
                "items",
                0,
                "company"
            ]
        },
        {
            "code": "too_small",
            "minimum": 1,
            "type": "string",
            "inclusive": true,
            "exact": false,
            "message": "String must contain at least 1 character(s)",
            "path": [
                "data",
                "sections",
                "experience",
                "items",
                1,
                "company"
            ]
        },
        {
            "code": "too_small",
            "minimum": 1,
            "type": "string",
            "inclusive": true,
            "exact": false,
            "message": "String must contain at least 1 character(s)",
            "path": [
                "data",
                "sections",
                "experience",
                "items",
                2,
                "company"
            ]
        },
        {
            "code": "too_small",
            "minimum": 1,
            "type": "string",
            "inclusive": true,
            "exact": false,
            "message": "String must contain at least 1 character(s)",
            "path": [
                "data",
                "sections",
                "experience",
                "items",
                3,
                "company"
            ]
        },
        {
            "code": "too_small",
            "minimum": 1,
            "type": "string",
            "inclusive": true,
            "exact": false,
            "message": "String must contain at least 1 character(s)",
            "path": [
                "data",
                "sections",
                "experience",
                "items",
                4,
                "company"
            ]
        }
    ],
    "name": "ZodError"
}

Expected Behavior

The importer/validator should recognise the accurate schema and handle the import accordingly.

Steps To Reproduce

Import a valid JSON Resume.

What browsers are you seeing the problem on?

Safari, Microsoft Edge, Chrome, Firefox

What template are you using?

None

Anything else?

Previous issue was opened in 2023 #1598 but was closed with no action. If there is no plan to support the JSON Resume schema, it should be removed as an option.

[JaedenRotondo]

@Shadowfita The experienceSchema requires that the company field have at least one character:

export const experienceSchema = itemSchema.extend({
  company: z.string().min(1), // current enforcement that the company field must have 1 character 
  position: z.string(),
  location: z.string(),
  date: z.string(),
  summary: z.string(),
  url: urlSchema,
});

Can you post the JSON section on experience? You can remove any sensitive information. I'd like to see if the JSON is truly valid because, if I understand correctly, no company names cause this validation error.

[Shadowfita]

@Shadowfita The experienceSchema requires that the company field have at least one character:

export const experienceSchema = itemSchema.extend({
company: z.string().min(1), // current enforcement that the company field must have 1 character
position: z.string(),
location: z.string(),
date: z.string(),
summary: z.string(),
url: urlSchema,
});
Can you post the JSON section on experience? You can remove any sensitive information. I'd like to see if the JSON is truly valid because, if I understand correctly, no company names cause this validation error.

Thanks for your reply. Below is a redacted example of my JSON Resume payload in the basics.work array. Every object in the work array has the same text in the 'company' field, and I receive an error for all 5 entries when attempting to import.

    {
      "title": "Principal Officer",
      "company": "Government Department",
      "location_city": " Australia",
      "employment_type": "Full-time",
      "start_date": "2022",
      "end_date": "Present",
      "responsibilities": [
        "Strategic and operational planning for the implementation of Initiatives."
      ],
      "accomplishments": [
       "Led the coordination of the pipeline with various divisions within the Department."
      ]
    }

[JaedenRotondo]

Hi @Shadowfita, I was able to replicate the issue. But there are some things I need to make sure of first.

Were you using the JSON Resume schema?

JSON Resume uses the following schema: https://jsonresume.org/schema, which doesn't match your basics.work array. In JSON Resume's Schema, the company field doesn't exist. Instead, it's called name. If you change this, the error will go away.

As for some more details about future changes:
I'd expect this to cause a validation error, but during initial validation, there is no requirement for the name field.
The error message is not the most helpful because it occurs after the resume is parsed from JSON Resume schema into the internal schema used by Reactive Resume. So instead of saying "missing name", it says "missing company" in your error message.

I suggest that we make name a required field in the JSON validation if it's to be required by the internal schema and cause errors on import.

[Shadowfita]

@JaedenRotondo That was it! Thank you very much, and good catch. An error on my part, and as you've pointed out, the error message just confused me more, haha.

Appreciate your help, thank you Jaeden.