Add url to mijnamsterdam notification context#68
Merged
Conversation
fhaver-amsterdam
approved these changes
Mar 26, 2026
frankfe-amsterdam
approved these changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a fixed “Mijn Amsterdam” portal URL into the notification context for the bridge service so downstream consumers can link users to the portal.
Changes:
- Add
urlinto the context built bybridge.mijnamsterdam’sNotificationService. - Extend the notification service test to assert the scheduled notification context includes the expected
url.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
bridge/mijnamsterdam/services/notifications.py |
Overrides build_context to inject a url into notification context. |
bridge/mijnamsterdam/tests/services/test_notifications.py |
Adds an assertion that the stored scheduled notification context contains the url. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fixed “Mijn Amsterdam” portal URL into the notification context for the bridge service so downstream consumers can link users to the portal.
Changes:
Add url into the context built by bridge.mijnamsterdam’s NotificationService.
Extend the notification service test to assert the scheduled notification context includes the expected url.
Affected services
Definition of done
make openapi-diff)make dev)make requirements)After PR created (and deployed on dev):
Other notes
GitHub Copilot was used in writing the code