Skip to content

Add url to mijnamsterdam notification context#68

Merged
jjbeekman merged 1 commit intomainfrom
mijnamsterdam/add-url-to-notification
Mar 26, 2026
Merged

Add url to mijnamsterdam notification context#68
jjbeekman merged 1 commit intomainfrom
mijnamsterdam/add-url-to-notification

Conversation

@jjbeekman
Copy link
Copy Markdown
Collaborator

@jjbeekman jjbeekman commented Mar 26, 2026

Adds a fixed “Mijn Amsterdam” portal URL into the notification context for the bridge service so downstream consumers can link users to the portal.

Changes:

Add url into the context built by bridge.mijnamsterdam’s NotificationService.
Extend the notification service test to assert the scheduled notification context includes the expected url.

Affected services

  • bridge

Definition of done

  • API is backwards compatible (make openapi-diff)
  • Swagger UI up-to-date & tested (make dev)
  • Dependencies updated (make requirements)
  • Infrastructure config updated (aapp_azure_infra)
  • Loadtests for relevant endpoints (aapp_testing_loadtests)

After PR created (and deployed on dev):

  • Manual check on dev (o) e.g. use feature via Swagger or admin panel
  • Sanity check on test app (check that dev environment is selected)

Other notes

GitHub Copilot was used in writing the code

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a fixed “Mijn Amsterdam” portal URL into the notification context for the bridge service so downstream consumers can link users to the portal.

Changes:

  • Add url into the context built by bridge.mijnamsterdam’s NotificationService.
  • Extend the notification service test to assert the scheduled notification context includes the expected url.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
bridge/mijnamsterdam/services/notifications.py Overrides build_context to inject a url into notification context.
bridge/mijnamsterdam/tests/services/test_notifications.py Adds an assertion that the stored scheduled notification context contains the url.

@jjbeekman jjbeekman merged commit bd111ed into main Mar 26, 2026
18 of 28 checks passed
@jjbeekman jjbeekman deleted the mijnamsterdam/add-url-to-notification branch March 26, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants