Skip to content

Fix failing construction-work import#69

Merged
jjbeekman merged 2 commits intomainfrom
construction-work/AM-681-failing-import
Mar 30, 2026
Merged

Fix failing construction-work import#69
jjbeekman merged 2 commits intomainfrom
construction-work/AM-681-failing-import

Conversation

@jjbeekman
Copy link
Copy Markdown
Collaborator

@jjbeekman jjbeekman commented Mar 26, 2026

Adds a missing field to the construction_work domain models to support importing project contact data that now includes an extra attribute, addressing the “failing construction-work import” issue.

Changes:

Add extra field to ProjectContact model.

Affected services

  • construction_work

Definition of done

  • API is backwards compatible (make openapi-diff)
  • Swagger UI up-to-date & tested (make dev)
  • Dependencies updated (make requirements)
  • Infrastructure config updated (aapp_azure_infra)
  • Loadtests for relevant endpoints (aapp_testing_loadtests)

After PR created (and deployed on dev):

  • Manual check on dev (o) e.g. use feature via Swagger or admin panel
  • Sanity check on test app (check that dev environment is selected)

Other notes

GitHub Copilot was used in writing the code

Copilot AI review requested due to automatic review settings March 26, 2026 16:08
@jjbeekman jjbeekman requested a review from a team March 26, 2026 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a missing field to the construction_work domain models to support importing project contact data that now includes an extra attribute, addressing the “failing construction-work import” issue.

Changes:

  • Add extra field to ProjectContact model.

@jjbeekman jjbeekman merged commit 23dddf5 into main Mar 30, 2026
24 checks passed
@jjbeekman jjbeekman deleted the construction-work/AM-681-failing-import branch March 30, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants