Add git-workflow plugin with /ship and /pr:review commands#10
Add git-workflow plugin with /ship and /pr:review commands#10AnExiledDev merged 2 commits intomainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request introduces a new Git Workflow Plugin that provides two slash commands: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.devcontainer/plugins/devs-marketplace/plugins/git-workflow/README.md (1)
20-20: Addtextlanguage tag to all three unlabelled fenced code blocks.markdownlint-cli2 (MD040) flags these at lines 20, 41, and 109. Adding
```textto each suppresses the warnings without altering rendering.🔧 Proposed fix
-``` +```text /ship [optional commit message hint](apply the same change to the blocks starting at lines 41 and 109)
Also applies to: 41-41, 109-109
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.devcontainer/plugins/devs-marketplace/plugins/git-workflow/README.md at line 20, Three fenced code blocks are missing a language tag and trigger markdownlint MD040; update each unlabelled block (the one containing "/ship [optional commit message hint]" and the two other similar unlabelled blocks in this README) to use the text language by changing the opening fence to "```text" so the blocks render the same but suppress the lint warnings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
@.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/pr-review/SKILL.md:
- Around line 79-82: The second grep invocation treats the glob patterns after
-- as filenames and thus bypasses stdin; replace it with a proper pipeline or
supported gh path filter. For example, pipe the diff into a second grep that
filters added lines and matches dependency filenames (e.g. use: gh pr diff $PR |
grep '^\+' | grep -E
'requirements.*\.txt|package.*\.json|Cargo\.toml|go\.mod|Gemfile') or, if gh pr
diff supports path arguments, call gh pr diff $PR -- "**/requirements*.txt"
"**/package*.json" "**/Cargo.toml" "**/go.mod" "**/Gemfile" to scope the diff to
those files instead of using -- with grep.
In
@.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/ship/SKILL.md:
- Around line 1-6: The frontmatter in SKILL.md is missing file-editing tools so
Phase 5 cannot modify code; update the allowed-tools array in the YAML header of
.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/ship/SKILL.md
to include the editing capabilities (add "Write", "Edit" and/or "MultiEdit")
alongside the existing entries so the skill can perform the "Fix Selected Items"
step; locate the YAML frontmatter block (the top-level keys
description/argument-hint/disable-model-invocation/allowed-tools) and modify the
allowed-tools value to include the editing tool names.
---
Nitpick comments:
In @.devcontainer/plugins/devs-marketplace/plugins/git-workflow/README.md:
- Line 20: Three fenced code blocks are missing a language tag and trigger
markdownlint MD040; update each unlabelled block (the one containing "/ship
[optional commit message hint]" and the two other similar unlabelled blocks in
this README) to use the text language by changing the opening fence to "```text"
so the blocks render the same but suppress the lint warnings.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.devcontainer/CHANGELOG.md.devcontainer/CLAUDE.md.devcontainer/config/defaults/settings.json.devcontainer/plugins/devs-marketplace/.claude-plugin/marketplace.json.devcontainer/plugins/devs-marketplace/plugins/git-workflow/.claude-plugin/plugin.json.devcontainer/plugins/devs-marketplace/plugins/git-workflow/README.md.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/pr-review/SKILL.md.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/ship/SKILL.mddocs/src/content/docs/reference/commands.md
.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/pr-review/SKILL.md
Show resolved
Hide resolved
.devcontainer/plugins/devs-marketplace/plugins/git-workflow/skills/ship/SKILL.md
Show resolved
Hide resolved
Merge conflict note:
|
Standalone git workflow commands that work independently of the EARS ticket lifecycle. /ship reviews changes, commits, pushes, and optionally creates a PR with user confirmation. /pr:review conducts aggressive analysis on any PR by number/URL or auto-detect and posts findings as a comment (never approves or merges). Both commands are optionally ticket-aware when context exists.
- ship/SKILL.md: Add Edit, Write to allowed-tools so Phase 5 "Fix Selected Items" can actually modify files - pr-review/SKILL.md: Fix broken grep invocation where glob patterns after -- were treated as filenames instead of filtering stdin - README.md: Add `text` language tag to 3 unlabelled fenced code blocks (markdownlint MD040)
5f4c897 to
0a7becc
Compare
Summary
git-workflowplugin with two standalone slash commands:/ship(review, commit, push, optional PR) and/pr:review(aggressive PR review, never merges)/ticket:work, but work fully standalone otherwiseChanges
git-workflow/withplugin.json,skills/ship/SKILL.md,skills/pr-review/SKILL.md,README.mdgit-workflowentrygit-workflow@devs-marketplace[Unreleased]section with both commandsTest plan
/shipwith staged changes — confirm full review, commit message approval, AskUserQuestion before PR/pr:review 42— confirm PR diff fetched, analysis posted as comment (not approval)/pr:reviewwith no argument on a branch with an open PR — confirm auto-detection/ticket:workcontext existsSummary by CodeRabbit
New Features
/ship: streamlined commit, push, and pull request creation workflow with code review/pr:review: review any pull request and post findings as commentsDocumentation