This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Slash command permissions. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the current limitations of the permission system for slash commands we essentially extend the functionality of our permission checking system to the slash commands.
Forgot to revert testing parameters. Updated the comments in the deploy command.
Fixed the help command, it will now respond if you supply an invalid command name, or alias. It will now display the help message if an alias is supplied. Updated the `messageCreate` event to output the error into the console. Updated the example config to take advantage of the Nullish coalescing operator
This resolves #153, instead of over-engineering the issue it was successfully reduced to this thanks to @WilsontheWolf
Contributor
|
All permission levels are working! |
Contributor
|
|
If the command executioner can, or can't execute the command with the nature of the permission system we **must** respond otherwise it will error out and inform the user that it failed, giving them the illusion that they can use the command.
YorkAARGH
added
enhancement
guidebot-class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:
The nature of this PR is to expand the permission checking that guidebot deploys with legacy commands to interaction commands until finer permission tuning is possible with slash commands.
The big caveat of expanding the custom permission system is that all slash commands (global and guild) will be seen as "usable" to every single user regardless.
For the Guild VS Global command discussion, additional logic will be required within the interaction, and or command to prevent execution of guild intended commands such as moderative, or server info commands in the global scope.
Semantic versioning classification: