Small Changes #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
closes #1 for me. If interested i would like to play with this more when i can and make it able to point at a directory then add headers to each segement for things like route folder on an API. That my use case and it would be very handy to segment by file. |
Just added an ending line-feed to keep GitHub from complaining.
Anadian
reviewed
Jun 27, 2020
Owner
Anadian
left a comment
Anadian
left a comment
There was a problem hiding this comment.
@goofballtech Thank you for the contribution; I'll definitely be merging this into master as soon as I've cleaned up a few other things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a .gitignore to keep the node_modules file form the repo. This is why the changelog is huge.
Tweaked the regex because i was getting no success with the one you had in there. Once that changed then your test strings did not give the expected outputs so i moved the tests into input and output files to make it easier to visualize the expected results and for demo purposes if people use the library.