make mip-mapping on by default#83
Merged
lilleyse merged 1 commit intoCesiumGS:masterfrom Jun 14, 2017
Merged
Conversation
rahwang
force-pushed
the
default-mip-mapping
branch
from
141a02b to
bac82ab
Compare
Contributor
|
CC @erich666 |
Contributor
|
@moneimne do you want to review and test this? |
|
Looks good to me! Tests pass and was able to load in a textured model into Cesium successfully. |
Contributor
|
One last request, please update CHANGES.md. |
rahwang
force-pushed
the
default-mip-mapping
branch
from
bac82ab to
d1ac581
Compare
Contributor
Author
|
Done @pjcozzi! |
Contributor
|
Thanks @rahwang |
Contributor
|
Very nice, thanks again! |
pjcozzi
reviewed
Jun 14, 2017
| ### 1.1.1 2017-04-25 | ||
|
|
||
| * Fixed `CHANGES.md` formatting. | ||
| * Change texture sampling to use NEAREST_MIPMAP_LINEAR by default [#83](https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/83). |
Contributor
There was a problem hiding this comment.
Was 1.1.1 released? Or should this go in a new TODO version until it is deployed?
Contributor
There was a problem hiding this comment.
Oh whoops, I'll fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81
@lilleyse