Modify highlighting #50
Conversation
| showSearchResults(featureIds) | ||
| //=========================== | ||
| { | ||
| this.unselectFeatures(); |
There was a problem hiding this comment.
Hmm, this used to be the behaviour and then a decision was made (a FCCB request??) to never zoom in to just the found features (and always zoom out so all found features are visible). Has this decision been reversed?
There was a problem hiding this comment.
I cannot find noZoomIn is used anywhere. Instead, the default zoomIn is set to false in the zoomToFeatures(). I assume the parameter noZoomIn was updated to zoomIn sometime in the past.
| animate: false | ||
| }) | ||
| return bbox | ||
| } |
There was a problem hiding this comment.
Although I understand how this can be used, I wonder about the rationale behind it, and the need for the caller to incrementally expand the selected features by passing in a bounding box, presumably returned from the previous call to zoomToFeatures().
If you are looking to improve performance by not unselecting and then reselecting previously selected features, then what about a new option called say selection, with values of clear (the default), expand (the current selected feature set is enlarged), and contract (the current selected feature set is shrunk)? Then the external client doesn't have to concern itself with internal representation.
Please raise an issue if you agree that this is better approach that will meet your needs -- it's straightforward for me to implement.
|
PR closed as the changes are not ideal. A new issue has been created. |
2 participants
The changes here are for the ticket - Improve Flatmap highlight/selection speed
options.sequenceis added to make sure the selected features will remain.bboxis returned and passed in to make sure the bounds will always fit.Currently, there is a short time delay when highlighting a large number of features. Allowing highlighting neuron paths by chunk should be able to minimize the time delay from paths selected to paths highlighted. Although the total time cost may remain the same.