This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Update Readme.md with RxSwift Styles #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional changes for RxSwift.
Granfalloner
reviewed
Dec 2, 2019
| This integer updates when foo happens to bar and is subscribed to. | ||
| Subscribe to this observable to get a predefined initial value and subsequent changes. | ||
| */ | ||
| myIntegerStream: Observable<Int> { get } |
Contributor
There was a problem hiding this comment.
During our discussion we seemed to decide not to make distinction in the naming between cold and hot observables, but only document underlying behavior.
Contributor
Author
There was a problem hiding this comment.
I think this proposal is clearer. Also, I suspect the number of instances in which we make use of observables that require subscriptions to update is going to be small to non-existent.
Contributor
There was a problem hiding this comment.
is going to be small to non-existent.
This is an overstatement. A lot of things can be modeled as a cold observable - e.g., network api request, user-initiated actions, etc.
Co-Authored-By: Vasyl Myronchuk <granfalloner@gmail.com>
Co-Authored-By: Vasyl Myronchuk <granfalloner@gmail.com>
Co-Authored-By: Vasyl Myronchuk <granfalloner@gmail.com>
Co-Authored-By: Vasyl Myronchuk <granfalloner@gmail.com>
evgeniyd
reviewed
Jan 7, 2020
| This integer is updated when foo happens to bar. | ||
| Subscribe to this observable to get its current value and subsequent changes. | ||
| */ | ||
| myIntegerStream: Observable<Int> { get } |
There was a problem hiding this comment.
Suggested change
| myIntegerStream: Observable<Int> { get } | |
| var myIntegerStream: Observable<Int> { get } |
evgeniyd
reviewed
Jan 7, 2020
| myIntegerStream: Observable<Int> { get } | ||
|
|
||
| // Defining a raw value is not preferred and should only be done in rare cases. | ||
| myInteger: Int { get } |
There was a problem hiding this comment.
Suggested change
| myInteger: Int { get } | |
| var myInteger: Int { get } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes for RxSwift.