Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

Conversation

@bspath-work
Copy link
Contributor

No description provided.

@dimaosipa
Copy link

As I mentioned earlier I like the idea. But in automated tests, we need to access various UIViews, which are not tracked. How would we handle accessibility identifiers for them?

@bspath-work
Copy link
Contributor Author

bspath-work commented Mar 16, 2020

As I mentioned earlier I like the idea. But in automated tests, we need to access various UIViews, which are not tracked. How would we handle accessibility identifiers for them?

We would need to add identifiers for untracked UIViews. If we use ReportingEvents as the base, they would likely end up being UIEvents that do not get sent to UCR, but do have values for adding accessibility identifiers.

@evgeniyd
Copy link

My main concerns here are:

  1. We have this proposal in Swift Style Guide, which is not quite related to the style (which is kinda OK, since we don't have other document)
  2. We use Accessibility Identifiers for tests, but their names are in a framework that is for reporting which makes things a little bit obscure

@Sky
Copy link

Sky commented Mar 16, 2020

As I mentioned earlier I like the idea. But in automated tests, we need to access various UIViews, which are not tracked. How would we handle accessibility identifiers for them?

We would need to add identifiers for untracked UIViews. If we use ReportingEvents as the base, they would likely end up being UIEvents that do not get sent to UCR, but do have values for adding accessibility identifiers.

Not sure if it's good idea considering the fact that we are aiming towards generated reporting constants/events from spec. Also there is probably no need to store accessibility identifiers in some centralized place.
Maybe we should just propose identifier format and add them separately from reporting.

@bspath-work
Copy link
Contributor Author

As I mentioned earlier I like the idea. But in automated tests, we need to access various UIViews, which are not tracked. How would we handle accessibility identifiers for them?

We would need to add identifiers for untracked UIViews. If we use ReportingEvents as the base, they would likely end up being UIEvents that do not get sent to UCR, but do have values for adding accessibility identifiers.

Not sure if it's good idea considering the fact that we are aiming towards generated reporting constants/events from spec. Also there is probably no need to store accessibility identifiers in some centralized place.
Maybe we should just propose identifier format and add them separately from reporting.

We could, but the structure and functional implementation of a separate format will strongly resemble what we currently already use for reporting, so it's creating additional work to recreate a very similar result.

@bspath-work
Copy link
Contributor Author

bspath-work commented Mar 16, 2020

My main concerns here are:

  1. We have this proposal in Swift Style Guide, which is not quite related to the style (which is kinda OK, since we don't have other document)

I asked where to propose this. Apparently, this is the best location for now.

  1. We use Accessibility Identifiers for tests, but their names are in a framework that is for reporting which makes things a little bit obscure

Accessibility identifiers will be used for more than testing, eventually. This idea leverages the work we've already put into creating identifiers that we currently use for reporting controls and screens.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants