Skip to content

Update README: LocalPrefs.Shared is Unity-only#48

Merged
kochounoyume merged 3 commits intofeature/shared-unity-onlyfrom
copilot/update-readme-localprefs-change
Mar 1, 2026
Merged

Update README: LocalPrefs.Shared is Unity-only#48
kochounoyume merged 3 commits intofeature/shared-unity-onlyfrom
copilot/update-readme-localprefs-change

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

  • Explore codebase to understand the changes to LocalPrefs.Shared
  • Update README.md (English):
    • Fix point 1 wording to match reviewer's intent
    • Remove Note callout from Quick Start section
    • Fix namespace to using AndanteTribe.IO.Unity;
  • Update README_JA.md (Japanese):
    • Fix point 1 with exact text requested by reviewer
    • Remove Note callout from クイックスタート section
    • Fix namespace to using AndanteTribe.IO.Unity;
Original prompt

This section details on the original issue you should resolve

<issue_title>LocalPrefs.Sharedの変更をREADMEに反映する</issue_title>
<issue_description>LocalPrefs.Shared を.NETでは使用できない変更を加えた(Unityでしか使用できない)ので、必要なREADMEの修正をする</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kochounoyume <78918084+kochounoyume@users.noreply.github.com>
Copilot AI changed the title [WIP] Update README to reflect changes in LocalPrefs.Shared Update README: LocalPrefs.Shared is Unity-only Mar 1, 2026
Copy link
Member

@kochounoyume kochounoyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README_JA.md Outdated
Comment on lines +59 to +60
> **Note:** `LocalPrefs.Shared` はUnityでのみ使用可能です(`LocalPrefs.Unity` が必要)。.NETの場合は、直接プレフスクラスをインスタンス化してください(下記参照)。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要(英語版も同じく)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 21998c7 — removed the Note callouts from both README.md and README_JA.md.

README_JA.md Outdated
LocalPrefsはこれらの問題を解消し、かつ高速な実装を提供します。

1. `LocalPrefs.Shared` の保存先はUnityの場合は `Application.persistentDataPath`、.NETの場合もそれに準じたパスが指定されます
1. `LocalPrefs.Shared` はUnityでのみ使用可能です(`LocalPrefs.Unity` が必要)。保存先はデフォルトで `Application.persistentDataPath`(Web以外)またはLocal storage(Web)になります
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ライブラリの売りをいうところで、変な説明になっている.

LocalPrefs.SharedLocalPrefs.Unity)の保存先は基本的に Application.persistentDataPath 、WebGLだと自動的に最適な保存先が指定されます。

これでおねがい

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 21998c7:

  • README_JA.md: `LocalPrefs.Shared` (`LocalPrefs.Unity`)の保存先は基本的に `Application.persistentDataPath` 、WebGLだと自動的に最適な保存先が指定されます。
  • README.md: The save path of LocalPrefs.Shared (LocalPrefs.Unity) defaults to Application.persistentDataPath. On WebGL, the optimal save destination is automatically configured.

Co-authored-by: kochounoyume <78918084+kochounoyume@users.noreply.github.com>
@kochounoyume kochounoyume marked this pull request as ready for review March 1, 2026 14:46
@kochounoyume kochounoyume merged commit 443db3c into feature/shared-unity-only Mar 1, 2026
1 check passed
@kochounoyume kochounoyume deleted the copilot/update-readme-localprefs-change branch March 1, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants