This repository was archived by the owner on Apr 9, 2024. It is now read-only.
xMore maximum player count#7
Closed
UsainSrht wants to merge 2 commits intoAndre601:masterfrom
UsainSrht:master
Closed
xMore maximum player count#7UsainSrht wants to merge 2 commits intoAndre601:masterfrom UsainSrht:master
UsainSrht wants to merge 2 commits intoAndre601:masterfrom
UsainSrht:master
Conversation
Owner
|
Not sure why this should be changed... |
Author
I thought it'd be more handy when its dynamic rather than boolean. |
Owner
|
Will look at it later when I'm back on my PC and have time. |
Andre601
suggested changes
Aug 17, 2022
| # | ||
| # Note that the placeholder will not be affected in the conditions. | ||
| # | ||
| # Read more: https://github.com/Andre601/AdvancedServerList/wiki/Profile#onemore |
Owner
There was a problem hiding this comment.
Suggested change
| # Read more: https://github.com/Andre601/AdvancedServerList/wiki/Profile#onemore | |
| # Read more: https://github.com/Andre601/AdvancedServerList/wiki/Profile#xmore |
| return oneMore; | ||
| } | ||
|
|
||
| public int getxMore() {return xMore;} |
Owner
There was a problem hiding this comment.
Please expand this method.
No use in collapsing it here.
Owner
|
I have to close this, as there would be an inherit flaw with that option. Even when set to 0 would it display the online count, which is not something I myself would want here... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.