simple_uart: use correct API for flushing#55
Merged
AndreRenaud merged 10 commits intoAndreRenaud:masterfrom Apr 28, 2026
Merged
simple_uart: use correct API for flushing#55AndreRenaud merged 10 commits intoAndreRenaud:masterfrom
AndreRenaud merged 10 commits intoAndreRenaud:masterfrom
Conversation
simple_uart: fix using of vsprintf simple_uart: support flow control on linux
* Added a list/describe test * Add some description info for /dev/ttySx uarts * simple_uart_term: describe things during listing
Owner
|
Isn't this is different behaviour to under Linux? This aborts all in-flight transactions, and discards their data, as opposed to stalling until they've left. Actually, I was confused about the Linux behaviour. This patch looks correct, it drops anything outstanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlushFileBuffers() does not work for most serial ports and adapters as they found out here:
serialport/node-serialport@60d1b27