Homework/activity 03#45
Open
torukai-go wants to merge 4 commits intoAndroid-Developer-Basic:homework/activity_03from
Open
Homework/activity 03#45torukai-go wants to merge 4 commits intoAndroid-Developer-Basic:homework/activity_03from
torukai-go wants to merge 4 commits intoAndroid-Developer-Basic:homework/activity_03from
Conversation
added 2 commits
February 26, 2023 16:51
antonkazakov
suggested changes
Mar 19, 2023
Contributor
antonkazakov
left a comment
antonkazakov
left a comment
There was a problem hiding this comment.
Привет. Оставил несколько комментариев
|
|
||
| private lateinit var imageView: ImageView | ||
| private lateinit var editProfileBtn: Button | ||
| private lateinit var pickedImageUri: Uri |
Contributor
There was a problem hiding this comment.
Если здесь значения не будет, но кнопку отправки нажать, то будет краш
| private lateinit var pickedImageUri: Uri | ||
| private var user = UserData("","","") | ||
|
|
||
| private val resultContract = registerForActivityResult(ActivityResultContracts.RequestPermission()){ granted -> |
Contributor
There was a problem hiding this comment.
- Rationale диалога не вижу
- Диалога перед тем как идти в настройки тоже не вижу
- У тебя в настройки ведет сразу после второго нажатия "Не давать разрешение", а должно вести в настройки
| android:id="@+id/input_name" | ||
| android:layout_width="wrap_content " | ||
| android:layout_height="wrap_content" | ||
| android:text="name" |
Contributor
There was a problem hiding this comment.
У тебя сейчас это как дефолтный текст в EditText, нужно поменять аттрибут на hint
Contributor
|
Детект проверки тоже не прошли. Убедись что по код-стайлу все ок |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.