Fixes: ViewModelFactory casting, billing setup, accessibility/events, serialization opt-ins, and UI/stability tweaks#62
Merged
Android-PowerUser merged 1 commit intocodex/analyze-technical-debt-and-complexity-o6bm9pfrom Mar 26, 2026
Conversation
There was a problem hiding this comment.
The code changes in this PR are clean and properly implemented. The migration from deprecated enablePendingPurchases() to the new PendingPurchasesParams builder pattern follows Google Play Billing Library best practices. The import addition and warning suppression are appropriate. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
610d328
into
codex/analyze-technical-debt-and-complexity-o6bm9p
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PendingPurchasesParamsAPI and harden background/foreground service behavior for screen capture and WebRTC.Description
ViewModelProvider.Factoryimplementation to rename the parameter tomodelClass, construct the ViewModel viawith(modelClass)and return it usingmodelClass.cast(...), and added LiveApi fallback handling forPhotoReasoningViewModelwhenlivemodels are selected.PendingPurchasesParams.newBuilder().enableOneTimeProducts()and added the corresponding import.@OptIn(ExperimentalSerializationApi::class)to multiple polymorphic DTO sealed classes used for Mistral/Puter/Service payloads to avoid serialization runtime issues.ScreenCaptureService(new actions/constants, more robust display metrics handling on API >= R, safer ImageReader/VirtualDisplay initialization) and added explicit error handling and logging.ScreenOperatorAccessibilityServiceby removing a problematic flag, restructuringonAccessibilityEventinto awhenswitch, refreshing the root node with rate-limiting, improving logs and button-name inference capitalization.Icons.AutoMirrored.Filled.Send, replacingDividerwithHorizontalDivider, making dialog callbacks explicit/unused-parameter suppressed, adding OOM handling during file import, and adding a "Skip All" option to overwrite confirmation.sendMessageWithRetry, WebRTC MediaProjection callback signature tweaks, and various suppressed unused parameters.ImageUtils.bitmapToBase64uses PNG and ignores thequalityparameter with a suppression, anddeleteFilereturn logic and logging were cleaned up.SignalingClient.postTasknow includes thehasScreenshotflag in posted task data.Testing
./gradlew assembleDebugwhich completed successfully../gradlew testand the test suite passed../gradlew lintand addressed warnings relevant to the modified areas, with no new critical lint errors reported.Codex Task