chore: clean up eslint warnings

[gabrypavanello]

Summary

Eliminates all lint warnings across the monorepo.

Changes

• eslint.config.js: Add override for CLI files and reporters to allow console statements (these are intentional for user output)
• serve.ts: Fix multi-line eslint-disable comments
• Multiple files: Remove unused eslint-disable directives (auto-fixed)

Files affected

• packages/codegen/src/app.ts
• packages/codegen/src/cli.ts
• packages/codegen/src/serve.ts
• packages/codegen/src/watcher.ts
• packages/core/src/middleware/types.ts
• packages/create-app/src/index.ts
• packages/testing/src/eval/mcp/providers/anthropic.ts

Testing

• ✅ pnpm nx run-many -t lint passes with 0 warnings
• ✅ All existing tests pass

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Centralized linting exceptions for CLI-related sources to allow console output in that scope and removed redundant inline lint directives across the codebase for cleaner annotations. No runtime or user-facing behavior changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Adds an ESLint override disabling the no-console rule for CLI and testing files, and removes inline eslint-disable comments across several source files; no functional or API changes.

Changes

Cohort / File(s)	Summary
ESLint Configuration eslint.config.js	Added an override block that disables the no-console rule for CLI- and testing-related source paths.
Codegen CLI/Serve/App/Watcher packages/codegen/src/app.ts, packages/codegen/src/cli.ts, packages/codegen/src/serve.ts, packages/codegen/src/watcher.ts	Removed inline eslint-disable/eslint-disable-line comments around console.* calls; no runtime changes.
Core Middleware packages/core/src/middleware/types.ts	Removed an inline ESLint disable directive before the final dispatch call.
Create App packages/create-app/src/index.ts	Removed an inline eslint-disable-next-line no-console comment in the dependency-install catch block.
Testing - Anthropic Provider packages/testing/src/eval/mcp/providers/anthropic.ts	Removed no-explicit-any lint-disable directives around assistant message content and response assignment; no behavior changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: clean up eslint warnings' accurately reflects the main objective of the changeset, which is to eliminate lint warnings across the monorepo.
Description check	✅ Passed	The description provides relevant context about the changes, including a summary of modifications to eslint.config.js, multiple source files, and testing confirmation that lint passes with 0 warnings.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Code Review: Clean up eslint warnings

Overall Assessment: ✅ APPROVED

This is a well-executed cleanup PR that systematically eliminates all lint warnings across the monorepo. The changes are clean, consistent, and follow the repository's strict type-safety and code quality standards.

---

✅ Strengths

1. Proper Architectural Solution

   • Rather than just adding eslint-disable comments everywhere, the PR correctly updates the ESLint config to whitelist intentional console usage in CLI/reporter files
   • The new override in eslint.config.js:115-131 is well-scoped with clear documentation
   • Uses glob patterns to target specific file types (**/evaluator.ts, **/reporter.ts, etc.)

2. Code Quality Improvements

   • Removes 21 unnecessary eslint-disable comments, improving code readability
   • Fixes multi-line eslint-disable comments in serve.ts that were awkwardly placed at end of lines
   • Maintains strict @typescript-eslint/no-explicit-any enforcement in production code

3. Consistency

   • All console statements in CLI entrypoints are now consistently handled
   • Follows the repository's pattern established in the test files override (line 108-113)

4. Testing

   • PR description confirms pnpm nx run-many -t lint passes with 0 warnings ✅
   • All existing tests pass ✅

---

🔍 Code Quality Analysis

eslint.config.js changes

The new override is well-designed:

• Good: Explicit file paths prevent accidental disabling elsewhere
• Good: Includes generator.ts which was missing from some changed files
• Consider: The glob patterns **/evaluator.ts and **/reporter.ts are broad. If there are concerns about accidentally matching files in node_modules or other packages, you could make them more specific (e.g., packages/testing/src/eval/**/evaluator.ts)

serve.ts cleanup (lines 109-353)

• Excellent: Removed 12 awkward end-of-line disable comments
• Correct: All console statements are now properly allowed via config
• Clean: Error handling and logging remain intact

anthropic.ts changes (lines 67-124)

• Good: Removed unnecessary any disable comment at line 71
• Concern: Line 124 still has const response: any = without a disable comment
  • This suggests the variable genuinely needs any type (Anthropic SDK response)
  • However: With @typescript-eslint/no-explicit-any: "error" enabled, this should fail linting
  • Question: Did you verify this passes? If so, there may be another override I'm missing

types.ts change (line 186)

• Good: Removed @typescript-eslint/no-confusing-void-expression disable
• Verified: Line 100 of eslint.config.js shows this rule is disabled for client packages, and line 178-183 shows the pattern is consistent

---

🐛 Potential Issues

1. Critical - Possible Lint Failure
   • packages/testing/src/eval/mcp/providers/anthropic.ts:71 has const content: any[] = [] without disable comment
   • packages/testing/src/eval/mcp/providers/anthropic.ts:124 has const response: any = without disable comment
   • These should trigger @typescript-eslint/no-explicit-any: "error" since this file is in packages/testing/
   • Action Required: Please verify lint actually passes. If it does, there may be a config override I missed. If not, these need disable comments or proper typing.

---

🔐 Security Concerns

None. This is a linting configuration change with no runtime behavior modifications.

---

⚡ Performance Considerations

None. The changes are purely cosmetic (removing comments) and config adjustments.

---

🧪 Test Coverage

• No new functionality added, so no new tests needed
• PR confirms existing tests pass
• Recommendation: Consider adding a CI check that fails on lint warnings (not just errors) to prevent regression

---

📋 Recommendations

1. High Priority: Verify the any types in anthropic.ts actually pass linting
2. Medium Priority: Consider adding explicit type annotations instead of any:

   // Line 71 - use Anthropic SDK types
   import type { MessageParam } from '@anthropic-ai/sdk/resources/messages';
   const content: Array<MessageParam['content'][number]> = [];
   
   // Line 124 - use SDK response type
   const response: Message = await anthropic.messages.create({...});

3. Low Priority: Consider tightening the glob patterns in the new ESLint override if you want to prevent accidental matches in unexpected locations

---

✅ Conclusion

This PR successfully achieves its goal of eliminating lint warnings with a clean, maintainable approach. The only blocker is verifying the any types in anthropic.ts are actually passing linting as expected.

Recommendation: Approve after confirming lint passes (or fixing the any types if it doesn't).

Great work maintaining code quality! 🎉

[claude]

Code Review: PR #121 - Clean up ESLint warnings

Summary

This PR successfully eliminates lint warnings across the monorepo by properly configuring ESLint overrides for CLI tools and removing unnecessary eslint-disable directives. The changes are well-organized and focused.

---

✅ Positive Aspects

1. Clear Intent: The PR has a focused purpose - eliminating all lint warnings while preserving intentional console output in appropriate places.

2. Proper ESLint Configuration: The new override block in eslint.config.js correctly identifies files where console statements are intentional (CLI tools, reporters) and disables the no-console rule for them.

3. Code Cleanup: Removing unnecessary eslint-disable directives improves code readability and reduces noise.

4. Multi-line Comment Fix: The cleanup in serve.ts properly reformats multi-line console statements that previously had awkward trailing eslint-disable comments.

---

⚠️ Issues Found

Critical: Explicit any types remain in production code

Location: packages/testing/src/eval/mcp/providers/anthropic.ts

The PR removes eslint-disable comments but leaves explicit any types in the code:

• Line 71: const content: any[] = [];
• Line 124: const response: any = await anthropic.messages.create({...

Problem: According to AGENTS.md line 55:

NEVER introduce any in production code; use unknown + narrowing (ESLint enforces @typescript-eslint/no-explicit-any).

And eslint.config.js line 44 shows:

"@typescript-eslint/no-explicit-any": "error",

Why this is critical:

• These any types violate the strict type-safety requirements of the codebase
• The ESLint rule should have caught these, but they may be in a test file exception zone
• However, packages/testing is production code (a published package), not test code

Recommendation:

1. Replace const content: any[] = [] with proper typing using Anthropic SDK types
2. Replace const response: any with the actual return type from anthropic.messages.create()
3. If types aren't available, use unknown and narrow with type guards

Example fix for line 71:

// Import proper types from @anthropic-ai/sdk
import type { MessageCreateParams } from '@anthropic-ai/sdk/resources/messages';

const content: Array<MessageCreateParams.ContentBlock> = [];

Example fix for line 124:

import type { Message } from '@anthropic-ai/sdk/resources/messages';

const response: Message = await anthropic.messages.create({
  // ... 
});

---

📋 Other Observations

1. ESLint Override Patterns: The glob patterns in the new override look comprehensive:

   • packages/codegen/src/cli.ts ✓
   • packages/codegen/src/serve.ts ✓
   • packages/codegen/src/app.ts ✓
   • packages/codegen/src/watcher.ts ✓
   • packages/codegen/src/generator.ts ✓ (not modified in this PR but included)
   • packages/create-app/src/index.ts ✓
   • Reporter patterns ✓

2. Consistency: The changes are consistent across all files - removing inline eslint-disable comments now that file-level overrides are in place.

3. No Behavioral Changes: The PR only touches linting configuration and comments, with zero impact on runtime behavior. ✅

---

🧪 Testing Notes

The PR description states:

✅ pnpm nx run-many -t lint passes with 0 warnings
✅ All existing tests pass

However, I recommend also running:

pnpm build && pnpm test && pnpm lint && pnpm typecheck

Per AGENTS.md line 53, this is required before finishing any task.

---

🔒 Security & Performance

• Security: No security concerns. This is purely a linting cleanup.
• Performance: No performance impact. Changes are to comments and configuration only.

---

📊 Test Coverage

No test changes needed since this PR doesn't modify behavior. However, the any types in anthropic.ts should be properly typed before merge to maintain type safety guarantees.

---

🎯 Recommendation

Request Changes - The explicit any types in packages/testing/src/eval/mcp/providers/anthropic.ts must be replaced with proper types before merging. This violates the repository's strict type-safety policy.

After fixing the any types:

• Re-run pnpm lint to ensure no new warnings
• Re-run pnpm typecheck to verify types are correct
• Then this PR will be ready to merge

---

📝 Suggested Follow-up

Consider adding a pre-commit hook or CI check that fails on ANY eslint warnings (not just errors) to prevent future accumulation of warnings.

Great work on the cleanup! Just need to address those any types to align with the codebase standards. 🚀