Closed
Conversation
Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.10 to 0.8.11. - [Release notes](https://github.com/tokio-rs/mio/releases) - [Changelog](https://github.com/tokio-rs/mio/blob/master/CHANGELOG.md) - [Commits](tokio-rs/mio@v0.8.10...v0.8.11) --- updated-dependencies: - dependency-name: mio dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
michaelgpt
added a commit
that referenced
this pull request
Nov 11, 2025
…synchronization This commit addresses three critical bugs (P0) and one enhancement (P1) in the V2 sync detection system that prevented nodes from properly detecting when they are behind the network and need to sync before producing blocks. ## Critical Bugs Fixed ### Bug #1: Placeholder Height Discovery - **Problem**: SyncActor used `status.connected_peers` (peer count) instead of actual chain height for sync target discovery - **Fix**: Added `chain_height` field to NetworkStatus and updated SyncActor to use actual blockchain height - **Impact**: Sync target height now correctly reflects network state ### Bug #2: Incorrect Sync State Reporting - **Problem**: `is_syncing` only returned true for 2 of 7 sync states, causing nodes at height 0 to report "synced" when network was 13+ blocks ahead - **Fix**: Replaced state-based logic with height comparison using 2-block tolerance - **Impact**: Sync status now accurately reflects whether node is behind network ### Bug #3: No-Op InitializeSyncState Handler - **Problem**: Handler logged message but took no action, leaving SyncActor in Stopped state with no sync triggered on startup - **Fix**: Implemented full initialization logic that queries storage height and triggers sync discovery - **Impact**: Sync now properly initializes on node startup ## Enhancement ### Faster Health Check on Startup - Added initial health check at T+5s (previously T+60s) - Enables faster detection of startup sync issues - Continues with 60-second periodic checks after initial check ## Files Modified - app/src/actors_v2/network/messages.rs: Added chain_height field, enhanced StartSync - app/src/actors_v2/network/network_actor.rs: Added get_network_status_async() - app/src/actors_v2/network/sync_actor.rs: Fixed height discovery, sync logic, handler - app/src/actors_v2/chain/handlers.rs: Implemented InitializeSyncState handler - app/src/actors_v2/chain/actor.rs: Added initial health check, updated trigger_sync - app/src/actors_v2/network/rpc.rs: Added chain_height to RPC responses - app/src/actors_v2/network/handlers/network_handlers.rs: Added chain_height field - Test files: Updated StartSync message construction ## Testing Before: Node-2 starting 30s after Node-1 incorrectly reported "Node is synced" at height 0 and attempted block production while 13+ blocks behind. Expected After: Node-2 detects it's behind, reports "Skipping block production - node is syncing", syncs to current height, then resumes block production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps mio from 0.8.10 to 0.8.11.
Changelog
Sourced from mio's changelog.
Commits
0328bdeRelease v0.8.117084498Fix warnings90d4fe0named-pipes: fix receiving IOCP events after deregisterc710a30Add v0.8.x to the CIc29e21cRelease v0.8.10Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.