Fixes integer underflow panic during sync rollback #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `head - 1` with `head.saturating_sub(1)` in sync error handling to prevent panic when attempting to rollback from height 0. Fixes integer underflow that occurs when: - Chain is empty (head = 0) - Sync encounters processing errors - Error handler attempts rollback to height -1 This prevents node crashes during initial sync with empty database. Resolves: [AN-263]
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical integer underflow bug that causes node crashes during sync rollback operations when the chain is empty (height 0). The fix replaces arithmetic subtraction with saturating subtraction to prevent panics.
- Replaces
head - 1andprev_height - 1with saturating subtraction equivalents - Prevents node crashes during initial sync with empty database
- Addresses error handling in two critical sync rollback scenarios
Improve the error handling in the rollback process by adding specific warnings for missing blocks when attempting to rollback from height 0. This change prevents unnecessary panic and provides clearer logging for rollback failures, enhancing the robustness of the chain's error management. Resolves: [AN-263]
Enhance the error handling during the rollback process by adding a specific check for when the head is at 0, preventing attempts to rollback from an invalid state. This change improves logging clarity and prevents unnecessary errors during chain operations. Resolves: [AN-263]
michaelgpt
deleted the
AN-263-alys-integer-underflow-panic-during-chain-sync-rollback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
head - 1withhead.saturating_sub(1)in sync error handling to prevent panic when attempting to rollback from height 0.Fixes integer underflow that occurs when:
This prevents node crashes during initial sync with empty database.
Resolves: [AN-263]