GUI: Fix build on clang++#95
Conversation
Clang complained about these.
We don't care about 3rd party warnings, and it broke the nix build on clang.
c3b7d76 to
3326f08
Compare
|
Rebased to get the new CI workflow |
|
Looks good to me, although I tried to forcibly build it with clang on my Ubuntu and it failed. But I'll blame that on the fact that I'm using a 2 year old version of clang (18.1.3). I also had to replace But it all doesn't matter, as my system was never meant to run clang in the first place. Still compiles with g++, and that's all that matters to me, haha. |
Did you do |
|
Yea, so turns out I was compiling with In my defence, the only 2 compilers I've ever used were |
Related to #66 (comment). After changes in #93, when using one of those clang-built kernels, the package.nix would also be built by a clang based stdenv. This gets us closer to having the nix package work with those kernels. However as the gui is currently in the same package, it will also be built by clang. It would probably make sense to split the gui to its own nix package that would then be built by the normal gcc based stdenv which would resolve this, however I don't think it's a bad idea to have the gui build passing on clang anyway. Different compilers have different warnings and all that, helping us catch more mistakes.
I have tested that the nix package (includes driver and GUI) and yeetmousectl still build.