Skip to content

Conversation

@lahma
Copy link
Contributor

@lahma lahma commented Nov 30, 2025

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Upgraded to NUKE 10 and latest GitHub Actions steps, removed unnecessary SDK installations from workflow.

@lahma lahma marked this pull request as ready for review November 30, 2025 13:47
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl FlorianRappl merged commit a0297a2 into AngleSharp:devel Nov 30, 2025
5 checks passed
@lahma lahma deleted the nuke-10 branch November 30, 2025 16:48
@jogibear9988
Copy link
Contributor

have you seen, that the future of nuke is uncertain: nuke-build/nuke#1564 (comment)

@FlorianRappl
Copy link
Contributor

nuke-build/nuke#1564 (comment)
nuke-build/nuke#1564 (reply in thread)

Not to mention we do not only just use NUKE - we are happy with it and there is no reason to change. And even if there would not have been a NUKE 10 we would still keep on using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants