Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions src/AngleSharp.Css.Tests/Declarations/CssPaddingProperty.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
namespace AngleSharp.Css.Tests.Declarations
{
using AngleSharp.Css.Dom;
using AngleSharp.Dom;
using NUnit.Framework;
using static CssConstructionFunctions;

Expand Down Expand Up @@ -139,5 +141,62 @@ public void CssPaddingShouldBeRecombinedCorrectly()
var actual = result.CssText;
Assert.AreEqual(expected, actual);
}

[Test]
public void CssPaddingImportantShouldNotBeOverriddenByNonImportant()
{
var snippet = "padding: 20px !important; font-size: 20px; padding: 0";
var style = ParseDeclarations(snippet);
var padding = style.GetPropertyValue("padding");
Assert.AreEqual("20px", padding);
var paddingProp = style.GetProperty("padding");
Assert.IsNotNull(paddingProp);
Assert.IsTrue(paddingProp.IsImportant);
var fontSize = style.GetPropertyValue("font-size");
Assert.AreEqual("20px", fontSize);
}

[Test]
public void CssPaddingImportantShouldBeOverriddenByImportant()
{
var snippet = "padding: 20px !important; padding: 0 !important";
var style = ParseDeclarations(snippet);
var padding = style.GetPropertyValue("padding");
Assert.AreEqual("0", padding);
var paddingProp = style.GetProperty("padding");
Assert.IsNotNull(paddingProp);
Assert.IsTrue(paddingProp.IsImportant);
}

[Test]
public void CssPaddingNonImportantShouldBeOverriddenByNonImportant()
{
var snippet = "padding: 20px; padding: 0";
var style = ParseDeclarations(snippet);
var padding = style.GetPropertyValue("padding");
Assert.AreEqual("0", padding);
}

[Test]
public void CssPaddingNonImportantShouldBeOverriddenByImportant()
{
var snippet = "padding: 20px; padding: 0 !important";
var style = ParseDeclarations(snippet);
var padding = style.GetPropertyValue("padding");
Assert.AreEqual("0", padding);
var paddingProp = style.GetProperty("padding");
Assert.IsNotNull(paddingProp);
Assert.IsTrue(paddingProp.IsImportant);
}

[Test]
public void CssInlineStyleImportantPaddingShouldTakePrecedence()
{
var html = "<p style=\"padding: 20px !important; font-size: 20px; padding: 0;\">Test</p>";
var dom = ParseDocument(html);
var p = dom.QuerySelector("p");
var style = p.GetStyle();
Assert.AreEqual("padding: 20px !important; font-size: 20px", style.CssText);
}
}
}
5 changes: 5 additions & 0 deletions src/AngleSharp.Css/Dom/Internal/CssStyleDeclaration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,11 @@ private void SetLonghand(ICssProperty property)

if (declaration.Name.Is(property.Name))
{
if (declaration.IsImportant && !property.IsImportant)
{
return;
}

_declarations[i] = property;
return;
}
Expand Down
Loading