Skip to content

Load performance CSS samples from disk instead of URLs. Fix issue running modern dotnet#201

Merged
FlorianRappl merged 1 commit intoAngleSharp:develfrom
jafin:perf/local-css-samples
Mar 27, 2026
Merged

Load performance CSS samples from disk instead of URLs. Fix issue running modern dotnet#201
FlorianRappl merged 1 commit intoAngleSharp:develfrom
jafin:perf/local-css-samples

Conversation

@jafin
Copy link
Copy Markdown
Contributor

@jafin jafin commented Mar 27, 2026

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Replace URL-based stylesheet loading with local CSS files to eliminate network dependency.
Several original URLs were dead or returning HTML error pages.
The 8 valid CSS files are now committed under Samples/ and loaded via the new FileTests class.
Also fix PlatformNotSupportedException from RuntimeHelpers.PrepareMethod on .NET 10.

Copy link
Copy Markdown
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I like the idea and I think this is a good one. We should just stick to the project (and with that I mean the convention across all AngleSharp repositories / projects) convention to use .NET class names instead of keywords (Boolean instead of bool, String instead of string etc.).

Rest looks awesome!

Replace URL-based stylesheet loading with local CSS files to eliminate
network dependency. Several original URLs were dead or returning HTML
error pages. The 8 valid CSS files are now committed under Samples/ and
loaded via the new FileTests class. Also fix PlatformNotSupportedException
from RuntimeHelpers.PrepareMethod on .NET 10.
@jafin jafin force-pushed the perf/local-css-samples branch from d14566b to d1cda64 Compare March 27, 2026 11:54
Copy link
Copy Markdown
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FlorianRappl FlorianRappl merged commit b2305f8 into AngleSharp:devel Mar 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants