Fix 0% losing its percent unit during CSS serialization#202
Merged
FlorianRappl merged 1 commit intoAngleSharp:develfrom Mar 28, 2026
Merged
Conversation
CssLengthValue.CssText unconditionally stripped all units when the numeric value was zero. Per CSS spec, 0 is valid without a unit for <length> values, but <percentage> values must always include the % sign since 0% and 0 have different semantic meanings (e.g. flex-basis).
Contributor
Author
|
The MDN docs I may misunderstand, or they don't adhere to their own docs. 
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/transform-origin So not really certain what the correct answer is here. Edit: ok here is what I understand. <body style="transform-origin: left 5px -3px;">const value = getComputedStyle(document.body).transformOrigin;
console.log(value);Computed style usually resolves percentages into pixels, based on the element’s size. |
Contributor
|
That's correct - there is a difference between the computed style and the default interpretation. |
Contributor
Author
|
I don't have any further advice on a resolution, I'll close this. |
Contributor
|
Why close it? |
FlorianRappl
approved these changes
Mar 28, 2026
Contributor
Author
|
@FlorianRappl sorry I misunderstood your response. I didn't see a way forward to resolve the desired output for the example you presented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Fix 0% losing its percent unit during CSS serialization
CssLengthValue.CssText unconditionally stripped all units when the
numeric value was zero. Per CSS spec, 0 is valid without a unit for
values, but values must always include the %
sign since 0% and 0 have different semantic meanings (e.g. flex-basis).
Resolves #172