Optimize GetInnerText with style caching and incremental computation#206
Merged
FlorianRappl merged 1 commit intoAngleSharp:develfrom Mar 28, 2026
Merged
Conversation
- Cache computed styles in a dictionary across the entire traversal so the same element is never computed twice (hit as element, parent, and sibling). - Hoist StyleCollection creation to the top of GetInnerText and reuse it throughout, eliminating repeated stylesheet enumeration and LINQ allocations. - When the parent's computed style is already cached, use incremental computation (ComputeDeclarationsWithParent) that inherits from the cached parent instead of walking all ancestors - replacing the O(depth) ancestor loop with a single UpdateDeclarations call.
FlorianRappl
approved these changes
Mar 28, 2026
Contributor
FlorianRappl
left a comment
There was a problem hiding this comment.
Definitely a GREAT one. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Related #55
Benchmark.net results from similar test to #55