Skip to content

Conversation

@AngryMaciek
Copy link
Owner

@AngryMaciek AngryMaciek commented Apr 15, 2023

Description

  • add preprocessor directive for Catch
  • correct typos
  • correct power-assignment tests for H[P]
  • add MPFR H^30 test to unit tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

@AngryMaciek AngryMaciek added bug Something isn't working enhancement New feature or request labels Apr 15, 2023
@AngryMaciek AngryMaciek self-assigned this Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1abd6b4) 100.00% compared to head (922a94d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          673       673           
=========================================
  Hits           673       673           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AngryMaciek AngryMaciek linked an issue Apr 15, 2023 that may be closed by this pull request
@AngryMaciek AngryMaciek linked an issue Apr 15, 2023 that may be closed by this pull request
@AngryMaciek AngryMaciek added the documentation Improvements or additions to documentation label Apr 15, 2023
@AngryMaciek AngryMaciek linked an issue Apr 21, 2023 that may be closed by this pull request
@AngryMaciek AngryMaciek changed the title [WIP] JOSS revision refactor: JOSS revision, round 1 Apr 21, 2023
@AngryMaciek AngryMaciek merged commit a8eee3f into master Apr 21, 2023
@AngryMaciek AngryMaciek deleted the revision branch April 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JOSS review] Some issues on references JOSS: MPFR assertion failed JOSS: unit tests

3 participants