[codex] Follow up local-ai staging for unpackaged Electron runs#175
Draft
joes021 wants to merge 3 commits into
Draft
[codex] Follow up local-ai staging for unpackaged Electron runs#175joes021 wants to merge 3 commits into
joes021 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/local-ai/<platform>-<arch>/binassets relative to the repo module pathbuild/local-ai/*while keeping the checked-in READMERoot cause
After PR #172 merged, source Electron smoke tests on Linux still fell back to GitHub release downloads. The app was resolving staged local-ai assets from
app.getAppPath(), which can point at the smoke harness directory instead of the repository root during unpackaged runs. Separately, staged runtime binaries were local build artifacts, so clean clones needed a restaging step and those artifacts should not pollute git status.Validation
node --test tests/localInferenceAssets.test.js tests/localInferenceProgress.test.jsxvfbafter restaginglinux-arm64binaries from the installed appxvfbafter restaginglinux-x64binaries from the installed app